Uploaded image for project: 'Apache Guacamole - Contributions'
  1. Apache Guacamole - Contributions
  2. GUAC-1041

Show / Hide OSK relies on keypress ordering

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 0.8.3
    • Fix Version/s: None
    • Component/s: guacamole-common-js
    • Labels:
      None

      Description

      In order to show / hide the OSK, the ordering of pressing / releasing CTRL-ALT-SHIFT is significant. This is due to this code in client-ui.js:

              // If lifting up on shift, toggle keyboard if rest of gesture
              // conditions satisfied
              if (show_keyboard_gesture_possible && keysym == 0xFFE1) {
                  if (keyboard.pressed[0xFFE3] && keyboard.pressed[0xFFE9]) {

      The issue here is that the shift key must be released whilst the other two keys are still pressed. If alt (for instance) is released first, the OSK won't be triggered / released. This should really look for the release of any of the keys whilst the other two are held down.

      Usability tests here have shown this causes issues (i.e. reports that the OSK doesn't work).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              abligh Alex Bligh
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: