Uploaded image for project: 'Apache Guacamole - Contributions'
  1. Apache Guacamole - Contributions
  2. GUAC-1086

TunnelRequestService.createTunnel method is too large

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 0.9.4
    • Fix Version/s: 0.9.7
    • Component/s: guacamole
    • Labels:
    • Sprint:
      DEV 2015-04-10
    • Story Points:
      1

      Description

      I want to reuse the most of the logic in the TunnelRequestService, but change a part which obtains connection details from the tunnel request.

      Currently, the createTunnel method is large, so to acheive the task I need to override the method and to copy the most of it's contents to the new one, which is not convenient. It would be good to split the method to a set of methods solving separate tasks, such as:

      • reading client information,
      • creating connected socket,
      • creating a tunnel associated with the connected socket.

      Then, to solve my task, I only need to override one of them.

        Attachments

          Activity

            People

            • Assignee:
              mike.jumper Michael Jumper
              Reporter:
              karatheodory Vasily Loginov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: