Uploaded image for project: 'Apache Guacamole - Contributions'
  1. Apache Guacamole - Contributions
  2. GUAC-1170

Fix build and browser warnings

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.7
    • Component/s: None
    • Labels:
      None
    • Sprint:
      DEV 2015-05-08
    • Story Points:
      5

      Description

      Although intended to be addressed in a past sprint, several warnings still occur and must be eliminated. In the browser:

      1. 'webkitAudioContext' is deprecated. Please use 'AudioContext' instead.
      2. 'KeyboardEvent.keyLocation' is deprecated. Please use 'KeyboardEvent.location' instead.
      3. Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.

      Warnings regarding missing plugin versions for several projects:

      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole:war:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 54, column 21
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-war-plugin is missing. @ line 63, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-common:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-javadoc-plugin is missing. @ line 78, column 21
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 54, column 21
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-source-plugin is missing. @ line 64, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-ext:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-javadoc-plugin is missing. @ line 78, column 21
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 54, column 21
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-source-plugin is missing. @ line 64, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-auth-jdbc-base:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 26, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-auth-jdbc-mysql:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 26, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-auth-jdbc-postgresql:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 26, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-auth-ldap:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 20, column 21
      [WARNING] 
      [WARNING] Some problems were encountered while building the effective model for org.glyptodon.guacamole:guacamole-auth-noauth:jar:0.9.6
      [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 20, column 21
      [WARNING] 
      [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
      [WARNING] 
      [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
      [WARNING]

      Warnings regarding the two .jar artifacts for each JDBC auth project:

      1. Configuration options: 'appendAssemblyId' is set to false, and 'classifier' is missing.
        Instead of attaching the assembly file: target/extension/guacamole-auth-jdbc-mysql-0.9.6.jar, it will become the file for main project artifact. NOTE: If multiple descriptors or descriptor-formats are provided for this project, the value of this file will be non-deterministic!
      2. Replacing pre-existing project main-artifact file: target/guacamole-auth-jdbc-mysql-0.9.6.jar
        with assembly file: target/extension/guacamole-auth-jdbc-mysql-0.9.6.jar
      3. Configuration options: 'appendAssemblyId' is set to false, and 'classifier' is missing.
        Instead of attaching the assembly file: target/extension/guacamole-auth-jdbc-postgresql-0.9.6.jar, it will become the file for main project artifact. NOTE: If multiple descriptors or descriptor-formats are provided for this project, the value of this file will be non-deterministic!
      4. Replacing pre-existing project main-artifact file: target/guacamole-auth-jdbc-postgresql-0.9.6.jar with assembly file: target/extension/guacamole-auth-jdbc-postgresql-0.9.6.jar

      Deprecated API (recompile with -Xlint:deprecation for details), probably GuacamoleProperties:

      1. GuacamoleSession.java
      2. MySQLAuthenticationProvider.java
      3. LDAPAuthenticationProvider.java
      4. NoAuthenticationProvider.java

      Unchecked/unsafe operations (recompile with -Xlint:unchecked for details):

      1. SimpleObjectPermissionSet.java
      2. TunnelModule.java
      3. ModeledObjectPermissionService.java
      4. LDAPAuthenticationProvider.java

      And then, finally, the slew of warnings about filename size in the source tar:

      [WARNING] Entry: guacamole-client-0.9.6/guacamole/src/main/java/org/glyptodon/guacamole/net/basic/rest/connectiongroup/ longer than 100 characters.
      [WARNING] Resulting tar file can only be processed successfully by GNU compatible tar commands
      [WARNING] Entry: guacamole-client-0.9.6/guacamole/src/main/java/org/glyptodon/guacamole/net/basic/rest/activeconnection/ longer than 100 characters.
      [WARNING] Entry: guacamole-client-0.9.6/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/schema/ longer than 100 characters.
      [WARNING] Entry: guacamole-client-0.9.6/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/ longer than 100 characters.
      [WARNING] Entry: guacamole-client-0.9.6/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/resources/ longer than 100 characters.
      ...

      The build should be modified to fail if such warnings are present, just like guacamole-server.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mike.jumper Michael Jumper
                Reporter:
                mike.jumper Michael Jumper
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: