Uploaded image for project: 'Apache Guacamole - Contributions'
  1. Apache Guacamole - Contributions
  2. GUAC-1655

Correct regression in handling of text selection

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: SSH, Telnet
    • Labels:
    • Sprint:
      DEV 2018-06-30
    • Story Points:
      5

      Description

      As described in upstream pull request #176

      The new bounds checks added for copying text from the scrollback buffer are incorrect for the case where the number of rows in scrollback has not yet reached at least the size of the terminal window. These changes remove those incorrect checks, instead modifying scrollback buffer row retrieval such that it is guaranteed to stay within bounds.

      This has technically already been fixed, however I am retroactively creating this issue for the sake of our own records.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mike.jumper Michael Jumper
              Reporter:
              mike.jumper Michael Jumper
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: