Uploaded image for project: 'Apache Guacamole - Contributions'
  1. Apache Guacamole - Contributions
  2. GUAC-735

Error making buffer.c/h from source

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2
    • Component/s: SSH, Telnet
    • Labels:
      None
    • Environment:
      Centos 6.5 VM
    • Sprint:
      DEV 2014-07-18
    • Story Points:
      2

      Description

      Cloned git today and got an error during "make":

      make[2]: Entering directory `/root/guacamole-server/src/terminal'
        CC     blank.lo
        CC     buffer.lo
      cc1: warnings being treated as errors
      buffer.c: In function ‘guac_terminal_buffer_set_columns’:
      buffer.c:204: error: ‘continuation_char.width’ may be used uninitialized in this function
      make[2]: *** [buffer.lo] Error 1
      make[2]: Leaving directory `/root/guacamole-server/src/terminal'
      make[1]: *** [all-recursive] Error 1
      make[1]: Leaving directory `/root/guacamole-server'
      make: *** [all] Error 2

      I was able to get it to build by commenting out one for loop and removing the variable j:

      void guac_terminal_buffer_set_columns(guac_terminal_buffer* buffer, int row,
              int start_column, int end_column, guac_terminal_char* character) {
       
          int i;
          guac_terminal_char* current;
       
          /* Build continuation char (for multicolumn characters) */
          guac_terminal_char continuation_char;
          continuation_char.value = GUAC_CHAR_CONTINUATION;
          continuation_char.attributes = character->attributes;
       
          /* Get and expand row */
          guac_terminal_buffer_row* buffer_row = guac_terminal_buffer_get_row(buffer, row, end_column+1);
       
          /* Set values */
          current = &(buffer_row->characters[start_column]);
          for (i = start_column; i <= end_column; i += character->width) {
       
              *(current++) = *character;
       
          }
       
          /* Update length depending on row written */
          if (character->value != 0 && row >= buffer->length)
              buffer->length = row+1;
      }

        Attachments

          Activity

            People

            Assignee:
            mike.jumper Michael Jumper
            Reporter:
            ibigpapa Troy_harrison
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: