Uploaded image for project: 'Apache Guacamole - Contributions'
  1. Apache Guacamole - Contributions
  2. GUAC-872

Page Up and Page Down are swapped

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.9.3
    • Fix Version/s: 0.9.4
    • Component/s: guacamole-common-js
    • Labels:
      None
    • Environment:
      Firefox
    • Sprint:
      DEV 2014-10-24
    • Story Points:
      1

      Description

      The key identifiers for Page Up and Page Down are swapped. Within Keyboard.js:

      /**
       * Map of known JavaScript keyidentifiers which do not map to typable
       * characters to their unshifted X11 keysym equivalents.
       * @private
       */
      var keyidentifier_keysym = {
          ...
          "PageDown": [0xFF55],
          "PageUp": [0xFF56],
          ...
      }

      Page Down is actually 0xFF56, while Page Up is 0xFF55.

      This means Page Up and Page Down will be handled in reverse by any browser supporting DOM3 key events (currently Firefox). Once pressed, they will remain stuck down, as the keysym of the lifted key will be derived from the keyCode, and THAT mapping is correct. From Guacamole's perspective, the lifted key was never pressed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mike.jumper Michael Jumper
              Reporter:
              mike.jumper Michael Jumper
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: